Implement changes to event path iteration #2536
Conversation
|
@pmdartus I noticed you opened whatwg/dom#742. Do you think that could be what's causing all the test failures? Even if not, you might be best-positioned to help @Zirro debug the issues here. |
|
I will try to debug soon. I am suspecting another issue with the spec if there are so many failures unrelated to |
|
With the change proposed whatwg/dom#742 (comment), tests start passing again. In the current state of the spec, the That being said there is still a test failure ( |
|
That was a mistake in that test, PR here: web-platform-tests/wpt#16307. |
|
Thanks for the info @annevk. |
|
@Zirro, up for updating this with whatwg/dom#750, and probably rolling the web platform tests too? |
Zirro
force-pushed
the
event-path-iteration
branch
from
91d9806
to
983c35b
Compare
|
I've updated the code to include the changes from whatwg/dom#750. |
Zirro
force-pushed
the
event-path-iteration
branch
from
983c35b
to
0c389bc
Compare
| @@ -377,7 +377,7 @@ describe("level2/events", () => { | |||
| this.plist.addEventListener("foo", this.monitor.handleEvent, true); | |||
| this.plist.addEventListener("foo", this.monitor.handleEvent, false); | |||
| this.plist.dispatchEvent(this.event); | |||
| assert.equal(this.monitor.atEvents.length, 4, 'should be at 4 events'); | |||
| assert.equal(this.monitor.atEvents.length, 2, 'should be at 2 events'); // Changed from 4 to 2 after https://github.com/whatwg/dom/commit/98564fc5284439d2555f545fa04288e230a37a03 | |||
There was a problem hiding this comment.
@domenic I'm not familiar enough with these older tests, but it might be worth verifying that this change isn't an indication of a problem with the spec change.
domenic
force-pushed
the
event-path-iteration
branch
from
0c389bc
to
69d9d03
Compare
This is an implementation of the changes made to the event path iteration in whatwg/dom#686, though it's currently causing many existing tests to fail. I've not yet been able to determine whether this is due to an issue with the spec or a bug in this implementation.