dispatchEvent now takes into account if an element has been disabled

[brendo]

Fixes #2665

[TimothyGu]

This is not correct. https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#enabling-and-disabling-form-controls:-the-disabled-attribute:concept-fe-disabled says:

A form control that is disabled must prevent any click events that are queued on the user interaction task source from being dispatched on the element.

So any special processing must only apply to click events. Edit: the event has to both have the name "click" as well as being a MouseEvent object, as click event is defined to be a MouseEvent.

Additionally, some places call _dispatch directly:

jsdom/lib/jsdom/living/helpers/events.js

Line 17 in e3744f5

return tryImplForWrapper(target)._dispatch(event, legacyTargetOverrideFlag);

It might be better to override _dispatch instead of the more public dispatchEvent.

[domenic]

That can't be the right part of the spec, because the user interaction task source is never involved in jsdom, I don't think.

The click() disabled handling is in the spec at https://html.spec.whatwg.org/multipage/interaction.html#activation:concept-fe-disabled.

For dispatchEvent, I cannot find any support in the spec for this. Furthmore, running the test in #2665 in Firefox shows that it matches jsdom.

So I don't think we should change this in jsdom, but there is a spec interop issue, apparently.

[domenic]

This is whatwg/html#2368

[domenic]

Since jsdom is behaving according to the spec here, we won't change anything.

[brendo]

Thanks for the replies! I meant to come back to this but forget. I'm glad it kicked off some discussion though 👍