refactor: Rename Window.js to Window‑impl.js

[ExE-Boss]

Pre‑requisite for #2835.

---

See #2764 for explanation.

[ExE-Boss]

I’ve now rebased this on top of #2548.

[TimothyGu]

I'm going to close this as #2835 is not ready yet. I would advise you to fold this into #2835 itself. Please try to get over your phobia of history rewriting tools in Git like rebase and interactive rebase. And also as a final advice, please use the commit message format that everyone else uses (i.e., not conventional commits) to save us some work when merging your PRs.

[ExE-Boss]

Actually, #2835 is ready.

[TimothyGu]

Well #2835 is still in draft mode…

[ExE-Boss]

I’ll undraft it after all its dependencies (including this and #2918) are merged.

[ExE-Boss]

Please try to get over your phobia of history rewriting tools in Git like rebase and interactive rebase.

I have learned the hard way to prefer git merge and only use squash and merge once a PR is ready when I accidentally FUBAR’d the codebase of NOVA-Team/NOVA-Monorepo#234 so much that javac would crash during compilation and I had to manually re‑create the history in order to roll‑back the changes which broke it in the first place.

Fixing that hot mess took several days.

---

please use the commit message format that everyone else uses (i.e., not conventional commits) to save us some work when merging your PRs.

I use a modified Angular commit message format, because that’s what I’m used to.

[domenic]

You're not going to be allowed to work on this project if you do not respect its conventions. Please follow @TimothyGu's advice.

[TimothyGu]

I use a modified Angular commit message format, because that’s what I’m used to.

Well, this may sound awfully obviously but, jsdom is not your project, and we don’t particularly care about what you are used to or not. It is well-known across open source and the software engineering world in general that when you contribute to someone else’s project, you follow their rules. Bringing your own style “is disrespectful, like someone tromping into a spotlessly-clean house with muddy shoes.”

As a maintainer, I have a choice to make every time you submit a PR that looks good otherwise: merge it and fix up all of the style things – myself – or just leave the PR be because it would be too much work to merge it. So far I’ve mostly been doing the former, but I’m telling you that it’s getting closer and closer to my limit.

Same with history rewriting. I don’t know how the heck you managed to do that, but I don’t particularly care. Benefits for using git rebase origin/master are clear in that it prevents things like jsdom/webidl2js#179 (comment).

All in all, I’m telling you to do these things that are standard practice at jsdom, whether you like it or not. You could choose to not abide by them, but in turn I could choose to not merge them. That’s just how it is.