feat: add support for window override #3087
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In my case I want to add Proxy to the `window` object to intercept property access to `window` from js code, however I find it almost impossible to override the `window` object with the new object which is wrapped by `Proxy`. So I suggest maybe through the return value of `options.beforeParse`, it could return a new override `window` object?
Suggest usage like following:
```js
const $ = new JSDOM(`<!DOCTYPE html><html>${htmlCode}</html>`, {
runScripts: "dangerously",
pretendToBeVisual: true
beforeParse(window) {
const handler = {
get: function(obj, prop) {
console.log(`reading window property: ${prop.toString()}`);
return obj[prop];
},
getOwnPropertyDescriptor(target, prop) {
console.log(`reading getOwnPropertyDescriptor ${prop}`);
return target[prop];
}
};
return new Proxy(window, handler);
}
}
);
```
|
What's this PR is going on? I recently need this feature in the same scene with you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my case I want to add Proxy to the
windowobject to intercept property access towindowfrom js code, however I find it almost impossible to override thewindowobject with the new object which is wrapped byProxy. So I suggest maybe through the return value ofoptions.beforeParse, it could return a new overridewindowobject?Suggest usage like following:
Or maybe is there any more reasonable solution for this situation?