Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement streams by adopting the reference implementation #3200

Draft
wants to merge 64 commits into
base: main
Choose a base branch
from
Draft

Implement streams by adopting the reference implementation #3200

wants to merge 64 commits into from

Commits on May 27, 2021

  1. Merge commit '0774e365e859ccffe8431441564ddd7bf202c0cf' as 'lib/jsdom… 

    …/living/streams'
    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    3bfba25 View commit details
    Browse the repository at this point in the history

  2. Squashed 'lib/jsdom/living/streams/' content from commit 033c6d90 

    git-subtree-dir: lib/jsdom/living/streams
git-subtree-split: 033c6d900c438371083785828c659e3150cf4847
    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    0774e36 View commit details
    Browse the repository at this point in the history

  3. Remove unneeded parts of streams repo

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    f58e402 View commit details
    Browse the repository at this point in the history

  4. Begin adapting to the outside-of-jsdom environment

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    7b5de92 View commit details
    Browse the repository at this point in the history

  5. Register streams

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    5e03c08 View commit details
    Browse the repository at this point in the history

  6. Rewrite imports

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    393edff View commit details
    Browse the repository at this point in the history

  7. Use jsdom's AbortSignal

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    d067e8d View commit details
    Browse the repository at this point in the history

  8. Enable streams web-platform-tests

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    1f92525 View commit details
    Browse the repository at this point in the history

  9. Globally disable jsshell tests

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    97e1dee View commit details
    Browse the repository at this point in the history

  10. Pass through globalObject to abstract ops

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    95f8a3d View commit details
    Browse the repository at this point in the history

  11. Mark some tests failing

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    066a88c View commit details
    Browse the repository at this point in the history

  12. Use wrappers for AbortSignal, DOMException

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    8969474 View commit details
    Browse the repository at this point in the history

  13. Always initialize _globalObject if necessary 

    Several types must retain globalObject references, for the purpose of 
creating other impls, but may be constructed without running their 
constructors.
    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    a107800 View commit details
    Browse the repository at this point in the history

  14. Save globalObject in InitializeReadableStream

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    e544546 View commit details
    Browse the repository at this point in the history

  15. Save globalObject in InitializeWritableStream

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    942da52 View commit details
    Browse the repository at this point in the history

  16. Save globalObject in SetUpReadableByteStreamController

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    1093ce0 View commit details
    Browse the repository at this point in the history

  17. Use Uint8Arrays and ArrayBuffers from the globalObject

    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    6f5f24b View commit details
    Browse the repository at this point in the history

  18. Mark transferable tests as fail-slow for now 

    These tests crash the harness in confusing ways, and in any case can't 
pass until postMessage() is more completely implemented.
    @ninevra
    ninevra committed May 27, 2021
    Configuration menu
    Copy the full SHA
    554b1ac View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Mark outdated tests failing for now

    @ninevra
    ninevra committed May 28, 2021
    Configuration menu
    Copy the full SHA
    eafe528 View commit details
    Browse the repository at this point in the history

  2. Mark remaining failing tests

    @ninevra
    ninevra committed May 28, 2021
    Configuration menu
    Copy the full SHA
    476e47a View commit details
    Browse the repository at this point in the history

  3. Fix lint issues

    @ninevra
    ninevra committed May 28, 2021
    Configuration menu
    Copy the full SHA
    0f06828 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2021

  1. Don't fake transfering buffers

    @ninevra
    ninevra committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    bec5fd1 View commit details
    Browse the repository at this point in the history

  2. Flatten streams directory hierarchy

    @ninevra
    ninevra committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    f3ac927 View commit details
    Browse the repository at this point in the history

  3. Revert "Rewrite imports" 

    This reverts commit 393edff.

Import rewrites are no longer needed now that files have been moved to
the appropriate directory.
    @ninevra
    ninevra committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    4073fbd View commit details
    Browse the repository at this point in the history

  4. Reregister streams

    @ninevra
    ninevra committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    544c638 View commit details
    Browse the repository at this point in the history

  5. Squashed 'lib/jsdom/living/streams/' changes from 033c6d90..8a7d92b5 

    8a7d92b5 Resolve BYOB reads immediately on cancel

git-subtree-dir: lib/jsdom/living/streams
git-subtree-split: 8a7d92b559c2b3f5028d9f48b49de90044be35c1
    @ninevra
    ninevra committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    c4a2865 View commit details
    Browse the repository at this point in the history

  6. Merge commit 'c4a2865a2032c2ee4dc1767b8c769c7482bf531f' into streams-… 

    …reference-subtree-move
    @ninevra
    ninevra committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    5c22cd2 View commit details
    Browse the repository at this point in the history

  7. Update web-platform-tests

    @ninevra
    ninevra committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    b1f75bd View commit details
    Browse the repository at this point in the history

  8. (Partially) update to-run for new web-platform-tests

    @ninevra
    ninevra committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    3607e6e View commit details
    Browse the repository at this point in the history

  9. Update to-run for streams web-platform-tests

    @ninevra
    ninevra committed Jun 2, 2021
    Configuration menu
    Copy the full SHA
    35588a0 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2021

  1. Cite the vm bug causing patched-global failures

    @ninevra
    ninevra committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    16fa7d4 View commit details
    Browse the repository at this point in the history

  2. Remove unused code 

    Accidentally left some of the detached-buffer check code behind.

Fixes lint issues.
    @ninevra
    ninevra committed Jun 3, 2021
    Configuration menu
    Copy the full SHA
    3a64fc0 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2021

  1. Remove reference implementation's licensing

    @ninevra
    ninevra committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    f9f8c73 View commit details
    Browse the repository at this point in the history

  2. Revert "Update web-platform-tests" 

    This reverts commit b1f75bd.
    @ninevra
    ninevra committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    e97f8c3 View commit details
    Browse the repository at this point in the history

  3. Revert "(Partially) update to-run for new web-platform-tests" 

    This reverts commit 3607e6e.
    @ninevra
    ninevra committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    7d20c24 View commit details
    Browse the repository at this point in the history

  4. Revert "Update to-run for streams web-platform-tests" 

    This reverts commit 35588a0.
    @ninevra
    ninevra committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    60569b1 View commit details
    Browse the repository at this point in the history

  5. Mark an incidentally fixed xhr test!

    @ninevra
    ninevra committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    26ad931 View commit details
    Browse the repository at this point in the history

  6. Begin fixing style

    @ninevra
    ninevra committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    2b3849c View commit details
    Browse the repository at this point in the history

  7. Change capitalization of abstract operations

    @ninevra
    ninevra committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    15fcd00 View commit details
    Browse the repository at this point in the history

  8. Capitalize ViewConstructor

    @ninevra
    ninevra committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    cd7f18f View commit details
    Browse the repository at this point in the history

  9. Fix function style

    @ninevra
    ninevra committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    8e3a327 View commit details
    Browse the repository at this point in the history

  10. Fix line length

    @ninevra
    ninevra committed Jun 7, 2021
    Configuration menu
    Copy the full SHA
    fba4fb5 View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2021

  1. Merge branch 'master' into streams-reference-subtree-move

    @ninevra
    ninevra committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    ac6b8b9 View commit details
    Browse the repository at this point in the history

  2. Revert "Revert "Update to-run for streams web-platform-tests"" 

    This reverts commit 60569b1.
    @ninevra
    ninevra committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    99864ae View commit details
    Browse the repository at this point in the history

  3. Mark a test dependent on free function postMessage 

    In browsers, postMessage(), when called as a free function (undefined
this), behaves as though called on the current global object; in JSDOM,
it instead throws. The test relies on the former behavior. Spec appears
not to define the behavior of postMessage() in this case.
    @ninevra
    ninevra committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    4243cb4 View commit details
    Browse the repository at this point in the history

  4. Disable readable byte streams

    @ninevra
    ninevra committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    6901cf3 View commit details
    Browse the repository at this point in the history

  5. Remove manual AbortSignal typechecking 

    Since AbortSignal in jsdom _is_ implemented via webidl2js, webidl2js can 
handle the typechecking itself.
    @ninevra
    ninevra committed Jun 16, 2021
    Configuration menu
    Copy the full SHA
    6afefd0 View commit details
    Browse the repository at this point in the history

Commits on Jun 17, 2021

  1. Use jsdom's mixin util

    @ninevra
    ninevra committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    f2f4c67 View commit details
    Browse the repository at this point in the history

  2. Remove uponFulfillment

    @ninevra
    ninevra committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    8625950 View commit details
    Browse the repository at this point in the history

  3. Remove uponRejection

    @ninevra
    ninevra committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    68b3b87 View commit details
    Browse the repository at this point in the history

  4. Remove transformPromiseWith

    @ninevra
    ninevra committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    8dfadd7 View commit details
    Browse the repository at this point in the history

  5. Remove uponPromise

    @ninevra
    ninevra committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    f47c653 View commit details
    Browse the repository at this point in the history

  6. Remove performPromiseThen

    @ninevra
    ninevra committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    7588448 View commit details
    Browse the repository at this point in the history

  7. Remove waitForAllPromise

    @ninevra
    ninevra committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    c73a20e View commit details
    Browse the repository at this point in the history

  8. Remove the promise sidetable 

    Should help clarify when a value is a promise _capability_ versus just a 
promise.
    @ninevra
    ninevra committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    beaac8f View commit details
    Browse the repository at this point in the history

  9. Remove assertions

    @ninevra
    ninevra committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    38f2007 View commit details
    Browse the repository at this point in the history

  10. Rename webidl.js to promises.js 

    Better reflects its current purpose.
    @ninevra
    ninevra committed Jun 17, 2021
    Configuration menu
    Copy the full SHA
    4ce3283 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2021

  1. Reenable tests blocked by nodejs/node#38918

    @ninevra
    ninevra committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    3e2cb56 View commit details
    Browse the repository at this point in the history

  2. Predefine globals in the VM to work around the bug

    @ninevra
    ninevra committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    5f574da View commit details
    Browse the repository at this point in the history

  3. Fix bug in readableStreamTee 

    Introduced in beaac8f ("Remove the promise sidetable")
    @ninevra
    ninevra committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    0104cb5 View commit details
    Browse the repository at this point in the history

  4. Fix lint errors

    @ninevra
    ninevra committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    b84ebcb View commit details
    Browse the repository at this point in the history

  5. Predefine global properties as non-enumerable

    @ninevra
    ninevra committed Jun 28, 2021
    Configuration menu
    Copy the full SHA
    0bfe33f View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2021

  1. Use this instead of globalThis for node 10 support

    @ninevra
    ninevra committed Jun 29, 2021
    Configuration menu
    Copy the full SHA
    3f05836 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2021

  1. Remove unneed support for resetQueue asserts

    @ninevra
    ninevra committed Jul 8, 2021
    Configuration menu
    Copy the full SHA
    c254c7b View commit details
    Browse the repository at this point in the history