Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MouseEvent: fix pageX/Y and offsetX/Y during dispatch #3514

Merged
merged 6 commits into from Apr 16, 2023

Commits on Mar 12, 2023

  1. MouseEvent: fix pageX/Y during dispatch

    Ensure that `pageX/Y` reflect the coordinate relative to the origin of the
    window at the time of init (i.e. `clientX/Y` plus `scrollX/Y`). We record it
    during init, since `scrollX/Y` may change, which could result in the wrong
    `pageX/Y` values; see added tuWPT.
    
    Also track the target-relative coordinate during init (still just `(0, 0)` in
    the absence of layout support). This doesn't fundamentally change any
    behavior, but makes the implementation more future proof, making it safer to
    start handling Image Button submitters when constructing the form data set;
    see jsdom#3496 where this code was extracted from.
    jenseng committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    23ad658 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f183b3d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    263d7b2 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2023

  1. Configuration menu
    Copy the full SHA
    5248f0b View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2023

  1. Address PR feedback

    jenseng committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    795f81e View commit details
    Browse the repository at this point in the history
  2. Tweak comments

    jenseng committed Apr 5, 2023
    Configuration menu
    Copy the full SHA
    9fd7bc4 View commit details
    Browse the repository at this point in the history