Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nwsapi dependency #3528

Closed
wants to merge 3 commits into from
Closed

Update nwsapi dependency #3528

wants to merge 3 commits into from

Conversation

regseb
Copy link

@regseb regseb commented Apr 12, 2023 •
edited

Fix #3416

Update nwsapi dependency: v2.2.2 to v2.2.3. This new version includes a fix for selecting elements with capital letters: dperini/nwsapi#79

@regseb regseb mentioned this pull request Apr 12, 2023
Closed
jdufresne
jdufresne reviewed Apr 14, 2023
View reviewed changes
package.json Outdated Show resolved Hide resolved
regseb and others added 2 commits April 14, 2023 08:42
@regseb @jdufresne
Update package.json
1b3b21c 
Co-authored-by: Jon Dufresne <jon.dufresne@gmail.com>
@regseb
Update yarn.lock
1ef6ac6
@regseb
Copy link
Author

regseb commented Apr 14, 2023

I have upgraded the version to 2.2.4.

@asamuzaK
Copy link
Contributor

FYI, v2.2.4 has not yet fixed the :not() issue.
See Infinite loop fixed but still getting error in selectors · Issue #83 · dperini/nwsapi

@dperini
Copy link

dperini commented Apr 15, 2023

@asamuzaK
both the following DOM queries are passing the tests here:

document.querySelectorAll("[tabindex]:not(slot):not([inert])")

const nodes = document.querySelectorAll('.foo:not(.bar):not([data-id="1"]');

domenic added a commit that referenced this pull request May 1, 2023
@domenic
Update nwsapi
f8dc471 
This fixes at least a few case-sensitivity bugs, as shown in the new test.

Closes #3392. Closes #3428. Closes #3416. Closes #3528 by superseding it.
@domenic domenic mentioned this pull request May 1, 2023
Merged
@domenic domenic closed this in #3540 May 1, 2023
@domenic domenic closed this in f75a9d1 May 1, 2023
@regseb regseb deleted the nwsapi branch May 1, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdufresne jdufresne jdufresne left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[XML] querySelector with two elements, one capitalized
4 participants
@regseb @asamuzaK @dperini @jdufresne