Replace nwsapi with selery #3535
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes jsdom#3015, jsdom#3416, jsdom#3427, jsdom#3432. Not all but partially jsdom#3362.
|
Closing for now |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3015, #3416, #3427, #3432.
Not all but partially #3362.
Motivation:
I think nwsapi is a very ambitious library, but IMHO there are some concerns for a popular library like jsdom to depend on it.
CSS Selectors can be nested and repeated, so it is very difficult to deal without creating an AST.
selery creates AST and retrieves DOM.
My only concern is that selery hasn't been updated in a long time, but I've heard from the developer that he plan to continue developing it.
See Question: Still active? · Issue #10 · danburzo/selery
About the tests:
I'm new to contributing to jsdom and don't know where or how to write proper tests.
I created a new test file for now, please correct me.