Add option to display invalid constraints on form validation in console #3583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think we want to add options to jsdom to make it behave less like a standards-compliant browser. I suggest you make your tests pass the same way you would make them pass in a real browser. For example, by setting the novalidate attribute on the form during the test. |
|
I'm very sorry. I did not properly read the PR. Reporting to the console is a good idea. In fact I think we should do it by default. |
|
@domenic Will you finish implementing the new function? I don't know how to pass the config variable correctly to the HTMLFormElement-impl.js - otherwise you can also help me how to do that. |
|
No, sorry, I don't have time to work on this myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #3249 a form must be valid to be submitted.
This PR intends to add a new config option
reportInvalidConstraintsToConsoleto help developers find error in their tests.In a regular web browser the browser informs the user on the failed form fields.
This option should bring this feature to jsdom to help developers indentify which fields are causing their form to not be submitted during testing.
This PR stills needs some work by someone who is familar with the dev. of jsdom. The config option is not correctly passed down to the HTMLFormElement-impl.js file yet. Softwaretests are still missing.
Feel free to edit and modify everything!