Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3628 #3637

Closed
wants to merge 2 commits into from
Closed

Fix #3628 #3637

wants to merge 2 commits into from

Conversation

sebamarynissen
Copy link
Contributor

@sebamarynissen sebamarynissen commented Dec 9, 2023 •
edited

Fixes #3628.

@sebamarynissen
Fix jsdom#3628
0d915b1
@sebamarynissen
Implement robust fix for jsdom#3628
4f2e98c 
Instead of borrowing atob and btoa from `globalThis` which can still go wrong if the functions were overriden there as well, it should now be fixed by always explicitly requiring atob and btoa from `node:buffer`
@domenic
Copy link
Member

domenic commented Dec 11, 2023

#3628 (comment)

@domenic domenic closed this Dec 11, 2023
@sebamarynissen sebamarynissen mentioned this pull request Dec 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsdom v23: atob (and btoa) in Window.js are recursive and always fail
2 participants
@sebamarynissen @domenic