Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: use Node built-in test runner with concurrency #3650

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

domenic
Copy link
Member

@domenic domenic commented Dec 28, 2023

This seems to mostly work. At least, it works for to-upstream web platform tests, going from 18.7 seconds (Node.js built-in runner, no concurrency) to 9.7 seconds (Node.js built-in runner, concurrency) on my system.

For normal web platform tests, I tried { concurrency: true } (equivalent to { concurrency: 31 } on my system) and it hung for a long time, before outputting a ton of failures, but also a good amount of successes. Most of the failures were ECONNREFUSED against the web platform tests server, i.e., I was probably DOSing myself. I'm trying { concurrency: 4 } now and results are streaming in, in a way that suggests they're being chunked and done concurrently. Maybe I can even bump it up? { concurrency: 8 } seemed to blow up though.

I'd want to do some more thorough measurements to make sure this gives a speedup as expected. E.g. run the whole suite, comparing Mocha vs. Node.js built-in runner vs. Node.js built-in runner without concurrency, more than one time.

More experimentation needed. And we'd want to port the whole suite away from Mocha, not just WPTs. Although obviously speeding up WPT execution time is highly impactful.

@domenic
Copy link
Member Author

domenic commented Jan 5, 2024

Something about the partially-passing web platform tests is not working. They all display the "Hey, did you fix a bug?" unexpected passing test error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant