New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update URLs that have been moved #3651
base: main
Are you sure you want to change the base?
Conversation
DanKaplanSES
commented
Jan 1, 2024
- These URLs now link directly to the moved location
I appreciate the URL changes, but I don't think it's good that you've changed the grammar and style to suit your voice instead of mine. (The extra "that" in "To write such a test that, simply" is indeed an error, though.) If you could revert such changes I'd accept this PR. Also, the package-lock.json change is not helpful. (Presumably you are using a different npm version than I.) |
@domenic Done. LMK if I missed anything. Thanks. |
Please also remove the package-lock.json change. |
- These URLs now link directly to the moved location
453792c
to
8987fa7
Compare
🤦♂️I'm so sorry for forgetting that a second time. |