wrap CEReactions code into try-finally

jsdom · Nov 26, 2019 · 9c62d29 · 9c62d29
1 parent 251a03c
commit 9c62d29
Show file tree

Hide file tree

Showing 2 changed files with 44 additions and 31 deletions.
diff --git a/test/__snapshots__/test.js.snap b/test/__snapshots__/test.js.snap
@@ -163,16 +163,17 @@ const iface = {
             });
 
             // CEReactions pre steps
-
-            const creating = !target[impl][utils.supportsPropertyName](P);
-            if (creating) {
-              target[impl][utils.namedSetNew](P, namedValue);
-            } else {
-              target[impl][utils.namedSetExisting](P, namedValue);
+            try {
+              const creating = !target[impl][utils.supportsPropertyName](P);
+              if (creating) {
+                target[impl][utils.namedSetNew](P, namedValue);
+              } else {
+                target[impl][utils.namedSetExisting](P, namedValue);
+              }
+            } finally {
+              // CEReactions post steps
             }
 
-            // CEReactions post steps
-
             return true;
           }
         }
@@ -226,16 +227,17 @@ const iface = {
           });
 
           // CEReactions pre steps
-
-          const creating = !target[impl][utils.supportsPropertyName](P);
-          if (creating) {
-            target[impl][utils.namedSetNew](P, namedValue);
-          } else {
-            target[impl][utils.namedSetExisting](P, namedValue);
+          try {
+            const creating = !target[impl][utils.supportsPropertyName](P);
+            if (creating) {
+              target[impl][utils.namedSetNew](P, namedValue);
+            } else {
+              target[impl][utils.namedSetExisting](P, namedValue);
+            }
+          } finally {
+            // CEReactions post steps
           }
 
-          // CEReactions post steps
-
           return true;
         }
         return Reflect.defineProperty(target, P, desc);
@@ -248,11 +250,12 @@ const iface = {
 
         if (target[impl][utils.supportsPropertyName](P) && !(P in target)) {
           // CEReactions pre steps
-
-          target[impl][utils.namedDelete](P);
-          return true;
-
-          // CEReactions post steps
+          try {
+            target[impl][utils.namedDelete](P);
+            return true;
+          } finally {
+            // CEReactions post steps
+          }
         }
 
         return Reflect.deleteProperty(target, P);
@@ -282,10 +285,11 @@ const iface = {
         }
 
         // CEReactions pre steps
-
-        return this[impl].method();
-
-        // CEReactions post steps
+        try {
+          return this[impl].method();
+        } finally {
+          // CEReactions post steps
+        }
       }
 
       get attr() {
@@ -294,8 +298,11 @@ const iface = {
         }
 
         // CEReactions pre steps
-        return this[impl][\\"attr\\"];
-        // CEReactions post steps
+        try {
+          return this[impl][\\"attr\\"];
+        } finally {
+          // CEReactions post steps
+        }
       }
 
       set attr(V) {
@@ -308,8 +315,11 @@ const iface = {
         });
 
         // CEReactions pre steps
-        this[impl][\\"attr\\"] = V;
-        // CEReactions post steps
+        try {
+          this[impl][\\"attr\\"] = V;
+        } finally {
+          // CEReactions post steps
+        }
       }
     }
     Object.defineProperties(CEReactions.prototype, {

diff --git a/test/test.js b/test/test.js
@@ -16,8 +16,11 @@ beforeAll(() => {
     processCEReactions(_, code) {
       return `
         // CEReactions pre steps
-        ${code}
-        // CEReactions post steps
+        try {
+          ${code}
+        } finally {
+          // CEReactions post steps
+        }
       `;
     },
     processHTMLConstructor(_, code) {