Verify test coverage for 'csaccess' source set during build #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome stuff as always - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a little PR for one of the To-Do comments in the build file, which was that we should verify test coverage for source files in the 'csaccess' source set during build. The rationale being that if only one call to the Checkstyle API remains uncovered, it may break the plugin with the next Checkstyle version.
I set the initial required coverage to our current coverage (which seems fine). It can be changed by modifying the MINIMUM_CSACCESS_COVERAGE constant.
This feature is made possible by the fact that Gradle decided to bring forward the feature originally planned for Gradle 4.0. Coverage verification is now possible starting with Gradle 3.4. I still had to upgrade from Gradle 3.2.1 which we were using.
Hope this helps!