Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting browser:true in .jshintrc does not cover some globals #3495

Open
rbruckheimer opened this issue Jul 28, 2020 · 5 comments · May be fixed by #3522
Open

Setting browser:true in .jshintrc does not cover some globals #3495

rbruckheimer opened this issue Jul 28, 2020 · 5 comments · May be fixed by #3522

Comments

@rbruckheimer
Copy link

The globals "customElements" and "ResizeObserver" ought to be added to the exports.browser object in vars.js.

@semmel
Copy link

semmel commented Sep 16, 2020

Yes indeed, I need to tend an ever growing list of globals in my .jshintrc file:

"predef": [ "AbortController", "crypto", "DOMException", "NetworkInformation", "customElements", "URLSearchParams"]

It's a little sad. 😢

@jugglinmike
Copy link
Member

Sounds about right to me. This is a good first issue--@rbruckheimer has explained exactly what needs to be done.

@JuanFML
Copy link

JuanFML commented Dec 16, 2020

Hi I am new here I could add try to do this as my first PR, but do I only have to add "customElements" and "ResizeObserver", to the exports.browser object in vars.js and set them as false? Or is something else needed first?

@semmel
Copy link

semmel commented Dec 16, 2020

@JuanFML please add all DOM interfaces and Window globals

That would be great!

@callmetushar123
Copy link

@jugglinmike I am new to Open source, Please assign this issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants