New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[[FEAT]] Added window globals and DOM interfaces to browser #3522
base: main
Are you sure you want to change the base?
Conversation
Can somebody help me with the errors? I don't understand where the problem is. |
Thanks for the patch! The build errors were due to an unrelated problem with As for this patch, it introduces a good deal more bindings than what has been In order to avoid confusion like this, we've taken to annotating new additions |
@JuanFML It's been a few months since we heard from you. Are you still interested in persuing this patch? |
Hello @jugglinmike I am sorry I haven’t been able to give it some time, if anyone wants to finish it or should we close the PR? |
@jugglinmike @JuanFML I would like to take this up and finish it. Before i proceed though, i would want to confirm how exactly you want the new additions to be annotated?
Is it like above or
Or like this? Or any other format. Please let me know and i would try to finish this PR. |
The former approach seems good to me! |
[[FEAT]] Added window globals and DOM interfaces to browser
Added DOM interfaces and Window globals into the exports.browser object in vars.js. In order to cover more globals .
Fixes #3495