empty case statements should not increase complexity #840 #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-wade
force-pushed
the
master
branch
2 times, most recently
from
df0bddc
to
184476b
Compare
|
see #840 (comment) |
|
I'm not sure I agree. In visual studio and intellij in C# and java respectively, complexity is NOT increased by an empty case statement. I also wonder outside of consistency with other operators within jshint how increasing complexity of an empty case makes sense? |
|
Superseded by gh-2597 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
case only increases complexity if the next statement is not immediately another case.