[[FIX]] Consistently lint evaluated code #3047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, upon encountering certain forms of dynamic code evaluation (namely the browser's `setTimeout` and `setInterval` functions), JSHint would attempt to lint the code being evaluated. Due to what appears to to be an unintentional typo on the JSHint source code, this behavior did not extend to code evaluated via the `Function` and `eval` functions. Extend this behavior to all forms of evaluated code.
rwaldron
reviewed
Oct 17, 2016
| @@ -2454,7 +2454,7 @@ var JSHINT = (function() { | |||
| left.value === "execScript") { | |||
| warning("W061", left); | |||
|
|
|||
| if (p[0] && [0].id === "(string)") { | |||
|
Rick and I have discussed this offline, and we've decided that unfortunately, While it is a bug fix, and Semantic Versioning supports fixing bugs (even those In light of that, I'm going to label this fix for inclusion in the next major |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, upon encountering certain forms of dynamic code evaluation
(namely the browser's
setTimeoutandsetIntervalfunctions), JSHintwould attempt to lint the code being evaluated. Due to what appears to
to be an unintentional typo on the JSHint source code, this behavior did
not extend to code evaluated via the
Functionandevalfunctions.Extend this behavior to all forms of evaluated code.
@rwaldron: This is about 3 bugs separated from a more important issue, but I
want to tackle each part on its own. What do you think about this? It's
backwards-breaking, but the current behavior is clearly inconsistent and clearly
the result of a typo.