Fixes #3455 #3456
Closed
Fixes #3455 #3456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only issue error E012 if a variable name has been given in the for-loop
|
Thanks for taking the time to write a patch! As per the project's contribution guidelines, we prefer changes to be backed with tests. Do you have the bandwidth to add a test for this fix? |
|
test is added and ran both with and without the fix to assure it reported the problem without the change and runs cleanly with the change. |
|
Great! Since this is a bug fix, I've merged this into the Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[[FIX]] E012 TypeError accessing 'value' of undefined
Make sure that 'decl.first[0]' is defined before accessing its 'value' attribute.
No breaking changes.
Fixes #3455