Fix cookie Max-Age to never be a floating point number

closes #39
jshttp · Oct 26, 2015 · ba8bd30 · ba8bd30
1 parent 7ebfa14
commit ba8bd30
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 1 deletion.
diff --git a/HISTORY.md b/HISTORY.md
@@ -1,3 +1,8 @@
+unreleased
+==========
+
+  * Fix cookie `Max-Age` to never be a floating point number
+
 0.2.2 / 2015-09-17
 ==================
 

diff --git a/index.js b/index.js
@@ -114,7 +114,7 @@ function serialize(name, val, options) {
   if (null != opt.maxAge) {
     var maxAge = opt.maxAge - 0;
     if (isNaN(maxAge)) throw new Error('maxAge should be a Number');
-    pairs.push('Max-Age=' + maxAge);
+    pairs.push('Max-Age=' + Math.floor(maxAge));
   }
 
   if (opt.domain) {

diff --git a/test/serialize.js b/test/serialize.js
@@ -54,9 +54,29 @@ test('maxAge', function() {
         maxAge: 1000
     }));
 
+    assert.equal('foo=bar; Max-Age=1000', cookie.serialize('foo', 'bar', {
+        maxAge: '1000'
+    }));
+
     assert.equal('foo=bar; Max-Age=0', cookie.serialize('foo', 'bar', {
         maxAge: 0
     }));
+
+    assert.equal('foo=bar; Max-Age=0', cookie.serialize('foo', 'bar', {
+        maxAge: '0'
+    }));
+
+    assert.equal('foo=bar', cookie.serialize('foo', 'bar', {
+        maxAge: null
+    }));
+
+    assert.equal('foo=bar', cookie.serialize('foo', 'bar', {
+        maxAge: undefined
+    }));
+
+    assert.equal('foo=bar; Max-Age=3', cookie.serialize('foo', 'bar', {
+        maxAge: 3.14
+    }));
 });
 
 test('firstPartyOnly', function() {