Pattern dependency feature

[bennycraig]

Q	A
Is bugfix?	❌
New feature?	✔️
Is backward-compatible?	✔️
Tests pass?	✔️
Fixed issues	1139
Updated README/docs?	✔️
Added CHANGELOG entry?	✔️

Hello! We (@Yeonhobo and me) finished implementing the feature which was requested in issue 1139 (regex pattern based dependency).

Here are the changes we made:

• modified checkDependency() in src/editor.js
• Added a test HTML page demonstrating how to use the feature → tests/pages/pattern-dependency.html
• Added end-to-end test showing it works as expected → tests/codeceptjs/pattern-dependency_test.js
• Added unit test → tests/unit/editors/object.spec.js
• Updated README: doc now explains how to use the pattern keyword for validation and pattern-dependency
• Added CHANGELOG entry

[schmunk42]

There's a little build error, see https://github.com/json-editor/json-editor/runs/6091139969?check_suite_focus=true#step:5:679

[bennycraig]

Sorry about that! We fixed the eslint error and just pushed to this branch again.

[schmunk42]

E2E Tests are failing, could you have another look.

[Yeonhobo]

Hello, sorry about the long wait we just added a quick fix for the E2E bud. Can you try building it another time and seeing if the errors persist? Thank you!

[schmunk42]

LGTM, @germanbisurgi please have a second look

[germanbisurgi]

• use const instead of var
• use same indentation as other tests
• add a @patttern-dependency tag
• use new codeceptjs syntax (tests will not pass if not)

from
Scenario('Second dependency', (I) => {})

to
Scenario('Second dependency', async ({ I }) => {}

[germanbisurgi]

This will trigger a merge conflict. It can be omitted because we update the CHANGELOG every time we make a release.

[germanbisurgi]

It works but some issues have to be addressed before we merge this.
I added comments in the single changed files there where changes are needed.