New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove empty arrays when remove_empty_properties is set #1423
base: master
Are you sure you want to change the base?
Conversation
@rmonnerat, do you have an idea why tests fail? (see e.g. https://github.com/json-editor/json-editor/actions/runs/6868513133/job/18698471271?pr=1423) |
I triggered the failed builds again, let's see if this was just a hickup. |
@navytux I don't know, I ran the |
@schmunk42 related: #1427 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wait for #1427 to be merged and test again, please
e5d3207
to
8e10cfc
Compare
@germanbisurgi I updated the branch, waiting for tests re-rerun. |
The tests show positive results, yet it would be beneficial to create an issue outlining the details along with a description and steps to reproduce the situation. This is to ensure we prevent any potential regression. |
The condition should check if the construct is an Array also, you can easily reproduce in plain javascript:
Otherwise, empty arrays ends up on the getValue result.