fix: When schema is readonly, input is disabled and readonly. #831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
problem: [readonly] and [disabled] attributes should be applied, but only readonly si applied on buld. disabled attribute is applied after show-hide property editor.
|
Some tests for "read-only" do not pass: https://travis-ci.com/github/json-editor/json-editor/jobs/396794375 |
schmunk42
added a commit
that referenced
this pull request
Mar 9, 2021
add more read-only tests for #831
|
Dear @schmunk42 @prespic I'm not sure I've understood: when the editor is 'readonly' the fields should be marked as readonly but absolutely not to disabled and vice versa. Actually this part of the documentation is a bit unclear: In a form if you disable a field it will not be sent to the server on post, if you mark it as read-only it will... Do we have a separated read-only feature for the editor? thanks |
|
It should work as you described, as far as I can see. AFAIK there's no |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
problem: [readonly] and [disabled] attributes should be applied, but only readonly si applied on buld. disabled attribute is applied after show-hide property editor.