Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/validation_error_placement #853

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Danielecina
Copy link

Q A
Is bugfix?
New feature? ✔️
Breaks backward-compatibility?
Tests pass? ✔️
Fixed issues comma-separated list of tickets # fixed by the PR, if any
Updated README/docs? ✔️
Added CHANGELOG entry? ✔️

Danielecina and others added 3 commits July 6, 2020 11:51
* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* Update validation.json

* Update validation.json

* Update validation.json

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* Update CHANGELOG.md

* Update src/themes/bootstrap4.js

* update(BMP-345): avanzamento

* Update src/defaults.js

* update(BMP-345): avanzamento

* update(BMP-345): avanzamento

* update(BMP-345): readme & constants

Co-authored-by: Daniele <daniele.cina@makeitapp.eu>
Co-authored-by: Federico Maggi <7142570+fredmaggiowski@users.noreply.github.com>
Copy link
Collaborator

@schmunk42 schmunk42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are onfOf errors handled, since they are currently displaying above the form?

README.md Show resolved Hide resolved
@Danielecina
Copy link
Author

How are oneOf errors handled, since they are currently displaying above the form?

currently "oneOf" works as other types

with GROUPED
Schermata 2020-11-02 alle 19 20 15

with below_fields
Schermata 2020-11-02 alle 20 13 29

@Danielecina Danielecina changed the title features/max_depth, use_default_values, validation_error_placement feature/validation_error_placement Nov 23, 2020
Copy link
Collaborator

@germanbisurgi germanbisurgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, could you explain with details what is the goal and how are you trying to achieve it?
I cloned your repo and tried to display error messages in differently but nothing changed.
Maybe with a example schema or better with a test? :)

@Danielecina
Copy link
Author

Hi, could you explain with details what is the goal and how are you trying to achieve it?
I cloned your repo and tried to display error messages in differently but nothing changed.
Maybe with a example schema or better with a test? :)

Currently work as in this example
#853 (comment)

With this changes i have the errors below the field and not outside of area

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants