test: cover ISO8601 date values accepted by Python 3.11 datetime module #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to fix few of these:
Done, shortened the longest descriptions. |
Python 3.11 `datetime` module allows additional ISO8601 date, time and date-time formats that are not RFC3339 5.6 compliant. This change adds tests for invalid `date` values that are at the moment allowed by at least Python `jsonschema` library as valid `date` sttrings. Looks like `date-time` and `time` test cases already cover at least some values that are valid by ISO8601 but not by RFC3339 section 5.6. See: * https://docs.python.org/3/whatsnew/3.11.html#datetime * python/cpython@1303f8c927 * https://docs.python.org/3.11/library/datetime.html#datetime.date.fromisoformat * https://www.rfc-editor.org/rfc/rfc3339#section-5.6 PR sent to `jsonschema` library python-jsonschema/jsonschema#1076.
jvtm
force-pushed
the
python311-date-iso8601-values
branch
from
8aa9aee
to
4248f3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.11
datetimemodule allows additional ISO8601 date, time and date-time formats that are not RFC3339 5.6 compliant.This change adds tests for invalid
datevalues that are at the moment allowed by at least Pythonjsonschemalibrary as validdatesttrings.Looks like
date-timeandtimetest cases already cover at least some values that are valid by ISO8601 but not by RFC3339 section 5.6.See:
PR sent to
jsonschemalibrary python-jsonschema/jsonschema#1076.