New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[馃摑 Docs]: The Bundling Section of The Structuring doc needs updating for v2012 #647
Comments
Welcome to the JSON Schema Community. We are so excited you are here! Thanks a lot for reporting your first issue!! 馃帀馃帀 Please make sure to take a look to our contributors guide if you plan on opening a pull request. For more details check out README.md file. |
Hi theory! |
Hi yourself :-) |
Could I help with this too? |
I wouldn't complain. |
I actually rewrote this entire page as part of the 2020-12 updates. So, it's up-to-date with the latest specification.
Non-relative URIs aren't required in
Using the URI for the
Not much really changed from 2019-09 to 2020-12. The recommendation about using URIs for embedded schemas in |
I can see that but since I was looking into how to bundle schemas, I found this a little confusing, because it appeared to require a change to the
Okay, good to know. I was a little confused because it only worked for me to use the ID as the object key (using the boon library). It's possible I did something wrong, will try again.
+1 |
@theory if what you are proposing which is adding a @benjagm what do you think?
Going with @theory on this one, because every documentation aims to provide clarity to the user, where there is clarity there is no confusion it is a seamless journey to implementation. If we define the I think we can implement a more consistent approach towards using the while going through the documentation in where using |
I do not have permission to assign people on this project. |
Thanks everyone! Who is finally going to implement the solution? Happy to assign the issue to them. |
@benjagm I updated my comment and I am open to work on this |
@theory and @jdesrosiers please I left a comment on slack in #contributor channel can you take a look and give me feedback Thanks |
Hi @Dule-martins ! Can you please add here the same question you shared in Slack? |
Okay, @benjagm In the page section for "understanding-json-schema/structuring#bundling" to be sure I understand what and where the change is required to be implemented is it expected of a contributor to update the JSON sample code on the page by using the full Within my drafted PR, the question I ask is what I did, but I am not sure if that is the correct thing to do. |
@Dule-martins, the answer is here
|
What Docs changes are you proposing?
It looks like the Bundling section of the Structuring doc needs updating for v2020-12. Proposed changes:
$id
in sub-schemas$id
string for$defs
keysDraft-specific info
tabCode of Conduct
The text was updated successfully, but these errors were encountered: