I updated the base URI and included a Draft-specific info box section #673
Conversation
Dule-martins
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
| In 2020-09, Only URI-references without fragments are allowed; | ||
| all other fragments in $id had undefined behavior previously. |
There was a problem hiding this comment.
We didn't discuss adding this and I'm not sure it belongs. This doesn't really address a change in behavior. This references something that was syntactically possible previously, but was entirely meaningless. The change was to forbid this syntax that didn't have any meaning anyway. For a reference at this level, I think this is a detail that's unnecessary to call out. It's fixing an inconsistency in the spec. I don't think users care about that.
Someone let me know if I'm missing something and there's a reason why this should be in UJS.
There was a problem hiding this comment.
Yes, I thought of adding it because I was trying to show the difference between Draft 2020-12 and 2020-9, but I can remove it @jdesrosiers
benjagm
added
the
Status: In Progress
|
Hi @Dule-martins . We are almost done with the changes to merge this PR. Can you please review the last comments? |
|
I will do that later tonight, after work thank you
…On Thu, 16 May 2024 at 13:33, Benjamin Granados ***@***.***> wrote:
Hi @Dule-martins <https://github.com/Dule-martins> . We are almost done
with the changes to merge this PR. Can you please review the last comments?
—
Reply to this email directly, view it on GitHub
<#673 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AH4ASUU3GMHYXK2KZUWJUGDZCSRQHAVCNFSM6AAAAABGTF7LU2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMJVGEZDSOJYGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
$idswere changed to absolute URIs. A Draft-specific Info block that supports changing dialects in an embedded schema (using $schema with a different value than the parent schema) with an explanation of the difference between 2020-09 and 2020-12What kind of change does this PR introduce?
refactoring doc
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?