Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure and rewrite What is JSON Schema Page in the overview section of the documentation for clarity #670

Closed
1 task done
Nickyshe opened this issue Apr 22, 2024 · 6 comments · Fixed by #679
Closed
1 task done
Assignees
Labels
📝 Documentation Indicates improvements or additions to documentation. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@Nickyshe
Copy link
Contributor

What Docs changes are you proposing?

After careful and detailed auditing, I found these problems in the documentation and require improvement.
The page What is JSON Schema under the overview section needs improvement in two areas:

  1. Structure of the content:
    Problem:
    The History of JSON Schema is added at this page's end.
    Solution:
    With the knowledge of Information architecture, the History of JSON Schema should be placed at the beginning of the documentation or created on a separate page. This provides a good flow of information for readers.

See the highlighted image below:
Screenshot (511)
2. Pronoun usage, active voice, and reduce redundancy.
Problem:
Third-person pronouns are not encouraged in writing technical documents unless in some special cases and depending on the context. This section used We to address the reader instead of You, which is the right pronoun to use when writing for your readers. The use of passive voice needs to be clarified for the reader about who is to perform an action.

Solution:

  • Use of second-person pronoun(you) to address the reader
  • Use of active voice
  • Make content concise to reduce redundancy
    see the highlighted image below: there are other contents with this issue that require modification
    Screenshot (512)

Link to What is JSON Schema page

Code of Conduct

  • I agree to follow this project's Code of Conduct
@Nickyshe Nickyshe added Status: Triage This is the initial status for an issue that requires triage. 📝 Documentation Indicates improvements or additions to documentation. labels Apr 22, 2024
Copy link

Welcome to the JSON Schema Community. We are so excited you are here! Thanks a lot for reporting your first issue!! 🎉🎉 Please make sure to take a look to our contributors guide if you plan on opening a pull request. For more details check out README.md file.

@gregsdennis
Copy link
Member

gregsdennis commented Apr 22, 2024

This section used We to address the reader instead of You, which is the right pronoun to use when writing for your readers.

While I would agree with this in a formal tech doc like a spec, this is informal and should be inviting. I think the pronoun use is fine, but it should be consistent.

@gregsdennis
Copy link
Member

The use of passive voice needs to be clarified for the reader about who is to perform an action.

What action? The user is reading docs. We (the author) aren't asking the reader to do anything.

@benjagm
Copy link
Collaborator

benjagm commented Apr 23, 2024

I think make the pronoun consistent will be a good addition. Using "You" is ok for me.

Regarding moving the story of JSON Schema on top, we tried it but we decided to move it down because the goal of this page is understand the problem solved by JSON Schema and why both developers and organizations use it... We think is good information but not requires its own section as of now.

Having said that, when we wrote this page I was convinced about the goal and structure but today I dont think the result is as good as I expected. My suggestion here is to change the objective of the issue to focus in the whole page and rewrite and restructure it for clarity.

What is not working?

  • I don't like the titles: "How it works" "The Challenge" "JSON Schema to the rescue" "Why developers use JSON Schema" and "Why organizations adopt JSON Schema" We can better highlight each section to improve flow and structure. I'd love the titles to inspire technical decision makers to use JSON Schema.

  • Code description : We are abusing of the structure "In the above code snippet, we ...." We should find a way to explain what is JSON Schema and why is so important using code in a more natural way just as complement. We are being soo much descriptive when explaining the code ... that is not working

  • The sections Why developers use JSON Schema and why organizations adopt JSON Schema requires an intro paragraph each and review every item to make sure the tone, is consistent.

  • Next steps section: Seems uncompleted like we didn't have the energy or motivation to complete it ... this section needs an intro paragraph to better close the flow and and better redirect people to:

    • Try yourself by creating your first schema
    • Read the docs to learn more
    • Join the Community to get involved

@Nickyshe Nickyshe changed the title Enhancement of the What is JSON Schema Page in the overview section of the documentation Restruction and rewrite What is JSON Schema Page in the overview section of the documentation for clarity Apr 23, 2024
@Nickyshe
Copy link
Contributor Author

@benjagm noted working on it

Additional information to be added

  • under this section there should be a heading for the use case of JSON Schema
    What do you think?

@Nickyshe Nickyshe changed the title Restruction and rewrite What is JSON Schema Page in the overview section of the documentation for clarity Restructure and rewrite What is JSON Schema Page in the overview section of the documentation for clarity Apr 24, 2024
@benjagm benjagm added Status: In Progress This issue is being worked on, and has someone assigned. and removed Status: Triage This is the initial status for an issue that requires triage. labels Apr 25, 2024
@himanshuaggar
Copy link

@benjagm, I would also like to work on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 Documentation Indicates improvements or additions to documentation. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants