Restructure what is JSON Schema for clarity #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to the JSON Schema Community. Thanks a lot for creating your first pull request!! 🎉🎉 We are so excited you are here! We hope this is only the first of many! For more details check out README.md file.
benjagm
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Thanks a lot Judith! This has been a great start. I added some comments:
- How it works:
- Add the missing image.
- Add section tittle and paragraph for context.
- We need to rephrase the titles of the benefits for developers and organizations to match the format "JSON Schema enable developers to ..." and "JSON Schema enable organizations to ..."
Excellent work so far. THANKS!
benjagm
added
the
Status: In Progress
benjagm
requested changes
May 13, 2024
There was a problem hiding this comment.
This is looking great @Nickyshe The simplification of the messaging makes it easier for readers to through all the content.
The only area I think we should continue working on "How JSON Schema works?" and for it I left some comments are suggestions.
Great job! We are very close!!
added new image(how-json-schema-works)
modified heading "How JSON Schema works"
benjagm
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This issue is for restructuring and rewriting what is Json schema page for clarity, consistent use of pronouns, revamp headings and ensure the tone is consistent throughout the documentation
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Yes I updated the documentation