Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved the design of TableOfContent custom tag. #650

Closed
wants to merge 5 commits into from

Conversation

vinfinity7
Copy link
Contributor

@vinfinity7 vinfinity7 commented Apr 14, 2024

What kind of change does this PR introduce?
This PR has updated the design of the TableOfContent custom tag .

Issue Number:

Screenshots/videos:
From
image

to

image

If relevant, did you update the documentation?
I have not updated the documentation till now .

Summary

Does this PR introduce a breaking change?

@vinfinity7 vinfinity7 requested a review from a team as a code owner April 14, 2024 04:15
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What a improvement! We are almost there.

I think will be better if all the lines have the same colour because now it is different (see image):

Screenshot 2024-04-15 at 08 02 59

I addition I think the circle should be filled with the same color than its border.

With this small improvements we'll be ready to merge.

Excellent work!!

@vinfinity7
Copy link
Contributor Author

Current State after reviewing the changes suggested
image

@vinfinity7
Copy link
Contributor Author

Linting is failing although it works on local ?

@DhairyaMajmudar
Copy link
Member

Linting is failing although it works on local ?

You can fix them by the suggestions given by workflow.

@vinfinity7
Copy link
Contributor Author

vinfinity7 commented Apr 15, 2024

Yes @DhairyaMajmudar , turns out the symbols that i've used aren't used by prettier , so I gotta think another way round for this

@benjagm
Copy link
Collaborator

benjagm commented Apr 23, 2024

@vinfinity7 let me know if you need help with this.

@benjagm benjagm added the Status: In Progress This issue is being worked on, and has someone assigned. label Apr 23, 2024
@gregsdennis
Copy link
Member

The second- and third-level indentions are different. The third level indents more from the second than the second does from the first.

@benjagm
Copy link
Collaborator

benjagm commented May 9, 2024

Hi @vinfinity7 are you still working on this? Shall we invite other contributors to give it a try?

@benjagm
Copy link
Collaborator

benjagm commented May 16, 2024

Closed for inactivity.

@benjagm benjagm closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Improve the design of TableOfContent custom tag.
4 participants