Feat/newsletter #681
Open
Feat/newsletter #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjagm
requested changes
Apr 30, 2024
There was a problem hiding this comment.
Great first step!!
Now we have the data and the functionality and we only need to improve design and user experience:
- Improve the hero section to replace the current subscribe form for a two columns design like Kubeweekly.
Column 1 : title, subtitle and link to submit content | Column 2 : Subscribe form.
- The area to show the newsletters require some changes:
- Remove the title "Previous JSON Schema Newsletter" and replace it for grouping by Year, in this case "2024". The left margin/padding needs to be fixed.
- Better to change the background color of this area with a light grey.
- The newsletters needs to be sorted in descending order from newest to oldest.
Great progress here!! Thanks!!
|
Thank you @Akshaybagai52 can you pls. change the destiny branch to |
Okay |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Issue Number:
Screenshots/videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?