Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use jspm API to generate package importmap #23

Closed
wants to merge 1 commit into from

Conversation

fusionstrings
Copy link
Contributor

No description provided.

@guybedford
Copy link
Member

Whenever possible I would recommend doing the in-browser generation. The API is more for environments that aren't able to do that.

@fusionstrings
Copy link
Contributor Author

Whenever possible I would recommend doing the in-browser generation. The API is more for environments that aren't able to do that.

I agree @guybedford .
Due to #18 and since the generator doesn't work yet in Deno (for SSR) I resorted to this temporarily.

Do you think it's a valid usecase?

@guybedford
Copy link
Member

@fusionstrings can we not do the generation on the client?

@fusionstrings
Copy link
Contributor Author

@fusionstrings can we not do the generation on the client?

I am investigating what might be wrong. So far this REPL works https://replit.com/@fusionstrings/jspm-packages-pull-23
https://jspm-packages-pull-23.fusionstrings.repl.co

@fusionstrings
Copy link
Contributor Author

@fusionstrings can we not do the generation on the client?

@guybedford here is another attempt to generate hash URLs but hashes are incorrect. Any idea what is wrong here? I am using same stateToHash function as in generator.jspm.io

@fusionstrings
Copy link
Contributor Author

fixed and superseded by #25.

@fusionstrings fusionstrings deleted the generate-importmap-from-api branch January 26, 2022 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants