Add a type converter for the InternetAddress type #884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xced
force-pushed
the
InternetAddressTypeConverter
branch
from
bb23163
to
8ee4e05
Compare
|
I'll have to think about this... |
0xced
force-pushed
the
InternetAddressTypeConverter
branch
from
8ee4e05
to
2650332
Compare
|
Can the TypeConverter classes be internal or do they have to be public for this to work? |
|
I think they could be internal but we would lose the ability to specify another ParserOptions with the Also, all the system type converter classes are public. |
|
Can you show me an example of how you intend to use this? I'm not very familiar with Microsoft.Extensions.Configuration and so I'm curious about how this would work. |
|
Will do next week when I'm back in front of a computer. |
|
@0xced Just figured I'd poke you since you are likely back from vacation now. |
This is useful to automatically convert strings to typed InternetAddress subclasses. For example, when using the `Microsoft.Extensions.Configuration` package.
0xced
force-pushed
the
InternetAddressTypeConverter
branch
from
2650332
to
f39f38c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful to automatically convert strings to typed InternetAddress subclasses. For example, when using the
Microsoft.Extensions.Configurationpackage.