Update vite to fix client pinging behind a proxy on WS disconnect #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes #0000
The current version of Vite in this project has a bug where when changes occur in the API behind a proxy (as in our case here), Vite pings the dev server to check the connection which is momentarily not running and throws an uncaught exception. This requires a manual refresh of the page which looks like this in the Shopify Admin:
This was making it difficult to extend the API in the app. I was constantly manually reloading the page.
WHAT is this pull request doing?
This updates Vite from
2.8.6to2.9.1to incorporate these changes: vitejs/vite#5466 which address this issue. The API still reloads and goes through the auth process, but the manual refresh is no longer needed. :)This doesn't violate any peer dependencies
