Skip to content

Commit

Permalink
fix(test): workflow use name instead. Fixes argoproj#12230
Browse files Browse the repository at this point in the history
Signed-off-by: oninowang <oninowang@tencent.com>
  • Loading branch information
jswxstw authored and oninowang committed Apr 23, 2024
1 parent e048a76 commit 2317852
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/e2e/suspend_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func (s *TestSuspendSitue) TestSuspendNodeTimeoutWithoutDefaultValue() {
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
generateName: suspend-node-timeout-without-default-value-
name: suspend-node-timeout-without-default-value
spec:
entrypoint: suspend
templates:
Expand Down Expand Up @@ -69,7 +69,7 @@ func (s *TestSuspendSitue) TestSuspendNodeTimeoutWithDefaultValue() {
apiVersion: argoproj.io/v1alpha1
kind: Workflow
metadata:
generateName: suspend-node-timeout-with-default-value-
name: suspend-node-timeout-with-default-value
spec:
entrypoint: suspend
templates:
Expand Down Expand Up @@ -110,15 +110,15 @@ spec:
assert.Equal(t, status.Progress, wfv1.Progress("2/2"))
}).
ExpectWorkflowNode(func(status wfv1.NodeStatus) bool {
return status.Name == "suspend-node-timeout-with-default-value-955vn[0].approve"
return status.Name == "suspend-node-timeout-with-default-value[0].approve"
}, func(t *testing.T, status *wfv1.NodeStatus, pod *apiv1.Pod) {
assert.Equal(t, wfv1.NodeSucceeded, status.Phase)
assert.Equal(t, 1, len(status.Outputs.Parameters))
assert.Equal(t, "message", status.Outputs.Parameters[0].Name)
assert.Equal(t, wfv1.AnyStringPtr("default message"), status.Outputs.Parameters[0].Value)
}).
ExpectWorkflowNode(func(status wfv1.NodeStatus) bool {
return status.Name == "suspend-node-timeout-with-default-value-955vn[1].release"
return status.Name == "suspend-node-timeout-with-default-value[1].release"
}, func(t *testing.T, status *wfv1.NodeStatus, pod *apiv1.Pod) {
assert.Equal(t, wfv1.NodeSucceeded, status.Phase)
assert.Equal(t, 1, len(status.Inputs.Parameters))
Expand Down

0 comments on commit 2317852

Please sign in to comment.