[New] eslint ^5 support #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
ljharb
commented
Jun 25, 2018
| @@ -11,6 +11,8 @@ cache: | |||
| yarn: true | |||
| directories: | |||
| - node_modules | |||
| before_script: | |||
| - if [ -n "${ESLINT-}" ]; then npm uninstall --no-save eslint-config-airbnb-base && npm install --no-save "eslint@${ESLINT}"; fi | |||
There was a problem hiding this comment.
the uninstallation part can be removed once airbnb/javascript#1834 is complete, and an eslint v5-compatible eslint-config-airbnb-base is published.
jessebeach
approved these changes
Jun 25, 2018
There was a problem hiding this comment.
LGTM.
@ljharb do you want to address your 'uninstallation' comment before merging?
beefancohen
approved these changes
Jun 25, 2018
|
@jessebeach it can't be addressed just yet; i'll clean it up in a followup once the base config is next published. |
|
@evcohen it'd be great if you could cut a release <3 (#452) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also improved the tests so we're testing on all supported eslint versions, and updated some deps.
There's currently one failing test on eslint 5; I'm working on that now.(linking back to airbnb/javascript#1834)