Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ESLint to v6 #603

Merged
merged 2 commits into from
Jun 26, 2019
Merged

Update ESLint to v6 #603

merged 2 commits into from
Jun 26, 2019

Conversation

jessebeach
Copy link
Collaborator

@jessebeach jessebeach commented Jun 23, 2019

Let's try just the addition of v6.

(ref #602)

@jessebeach jessebeach force-pushed the another-attempt-at-eslint-v6 branch 3 times, most recently from 7205183 to 22053a7 Compare June 23, 2019 20:14
@jessebeach jessebeach changed the title Update ESLint to v6 Update ESLint to v6, keep ESLint V3 peer dependency Jun 23, 2019
.travis.yml Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.557% when pulling 22053a7 on another-attempt-at-eslint-v6 into 416ca1b on master.

@coveralls
Copy link

coveralls commented Jun 23, 2019

Coverage Status

Coverage remained the same at 99.557% when pulling b07d8ec on another-attempt-at-eslint-v6 into f1b61e3 on master.

@jessebeach jessebeach force-pushed the another-attempt-at-eslint-v6 branch 6 times, most recently from 5c57815 to b07d8ec Compare June 23, 2019 22:09
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be blocked on import-js/eslint-plugin-import#1393

@jessebeach jessebeach changed the title Update ESLint to v6, keep ESLint V3 peer dependency Update ESLint to v6 Jun 23, 2019
@jessebeach
Copy link
Collaborator Author

@ljharb ok, I think this is it. Just blocked on airbnb/javascript#2036

@ljharb
Copy link
Member

ljharb commented Jun 24, 2019

@jessebeach try with v2.18.0 of the import plugin.

@jessebeach jessebeach force-pushed the another-attempt-at-eslint-v6 branch 2 times, most recently from 8021da5 to 91f17be Compare June 26, 2019 04:31
@jessebeach jessebeach merged commit e3163e3 into master Jun 26, 2019
@jessebeach jessebeach deleted the another-attempt-at-eslint-v6 branch June 26, 2019 04:43
@jessebeach
Copy link
Collaborator Author

jessebeach commented Jun 26, 2019 via email

@ljharb ljharb mentioned this pull request Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants