Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add example for tabIndex on seemingly non-interactive element #760

Merged
merged 1 commit into from Dec 27, 2020
Merged

docs: Add example for tabIndex on seemingly non-interactive element #760

merged 1 commit into from Dec 27, 2020

Conversation

eps1lon
Copy link
Contributor

@eps1lon eps1lon commented Dec 1, 2020

Closes #717

@eps1lon eps1lon mentioned this pull request Dec 1, 2020
Closed
ljharb
ljharb approved these changes Dec 26, 2020
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the comma

docs/rules/no-noninteractive-tabindex.md Outdated Show resolved Hide resolved
@ljharb ljharb force-pushed the patch-1 branch 2 times, most recently from fe6d881 to 066ccff Compare December 27, 2020 06:24
@codecov
Copy link

codecov bot commented Dec 27, 2020 •
edited

Codecov Report

Merging #760 (066ccff) into master (6b19aa5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #760   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          98       98           
  Lines        1452     1452           
  Branches      477      477           
=======================================
  Hits         1441     1441           
  Misses         11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b19aa5...066ccff. Read the comment docs.

@ljharb ljharb merged commit 066ccff into jsx-eslint:master Dec 27, 2020
@eps1lon eps1lon deleted the patch-1 branch December 27, 2020 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@jessebeach jessebeach jessebeach approved these changes

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add context to no-noninteractive-tabindex on when this might be valid
3 participants
@eps1lon @ljharb @jessebeach