Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Simplify the differences table in main doc #779

Closed
wants to merge 1 commit into from

Conversation

denis-sokolov
Copy link
Contributor

@denis-sokolov denis-sokolov commented Mar 2, 2021

The heading of the section says “difference”, yet most of the rows have no difference, leading to a confusion.

Alternatively, I would suggest renaming the section to “Exhaustive detail of recommended and strict configurations”.

Related: #238.

The heading of the section says “difference”, yet most of the rows have no difference, leading to a confusion.
@codecov
Copy link

codecov bot commented Mar 2, 2021

Codecov Report

Merging #779 (9d39045) into master (c275964) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #779   +/-   ##
=======================================
  Coverage   99.24%   99.24%           
=======================================
  Files          98       98           
  Lines        1452     1452           
  Branches      477      477           
=======================================
  Hits         1441     1441           
  Misses         11       11           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c275964...a074e91. Read the comment docs.

@jessebeach
Copy link
Collaborator

Alternatively, I would suggest renaming the section to “Exhaustive detail of recommended and strict configurations”.

@denis-sokolov this is a workable suggestion. Could you PR this?

@denis-sokolov
Copy link
Contributor Author

@jessebeach, sure! #786

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants