Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] control-has-associated-label: don't accept whitespace as an accessible label (Fixes #918) #919

Merged
merged 1 commit into from Jan 25, 2023

Conversation

wobo-nate
Copy link
Contributor

Fixes #918

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Merging #919 (93f7885) into main (20b082a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #919   +/-   ##
=======================================
  Coverage   99.28%   99.28%           
=======================================
  Files         104      104           
  Lines        1545     1547    +2     
  Branches      519      520    +1     
=======================================
+ Hits         1534     1536    +2     
  Misses         11       11           
Impacted Files Coverage Δ
src/util/mayHaveAccessibleLabel.js 97.14% <100.00%> (+0.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

control-has-associated-label accepts whitespace as a label
2 participants