make fixer fix one more case

jsx-eslint · Sep 1, 2019 · 0245d24 · 0245d24
1 parent c025438
commit 0245d24
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 8 deletions.
diff --git a/lib/rules/jsx-no-useless-fragment.js b/lib/rules/jsx-no-useless-fragment.js
@@ -13,18 +13,18 @@ function isJSXText(node) {
 }
 
 /**
- * @param {ASTNode} node
- * @returns {boolean}
+ * @param {string} text
  */
-function isJSXTextOrJSXCurly(node) {
-  return isJSXText(node) || node.type === 'JSXExpressionContainer';
+function isOnlyWhitespace(text) {
+  return text.trim().length === 0;
 }
 
 /**
- * @param {string} text
+ * @param {ASTNode} node
+ * @returns {boolean}
  */
-function isOnlyWhitespace(text) {
-  return text.trim().length === 0;
+function isNonspaceJSXTextOrJSXCurly(node) {
+  return (isJSXText(node) && !isOnlyWhitespace(node.raw)) || node.type === 'JSXExpressionContainer';
 }
 
 /**
@@ -138,7 +138,7 @@ module.exports = {
         }
 
         // const a = <>cat {meow}</>
-        if (node.children.some(isJSXTextOrJSXCurly)) {
+        if (node.children.some(isNonspaceJSXTextOrJSXCurly)) {
           return false;
         }
       }

diff --git a/tests/lib/rules/jsx-no-useless-fragment.js b/tests/lib/rules/jsx-no-useless-fragment.js
@@ -96,6 +96,18 @@ ruleTester.run('jsx-no-uselses-fragment', rule, {
       errors: [{messageId: 'NeedsMoreChidren'}],
       parser: parsers.BABEL_ESLINT
     },
+    {
+      code: `
+        <>
+          <div/>
+        </>
+      `,
+      output: `
+        <div/>
+      `,
+      errors: [{messageId: 'NeedsMoreChidren'}],
+      parser: parsers.BABEL_ESLINT
+    },
     {
       code: '<Fragment />',
       errors: [{messageId: 'NeedsMoreChidren'}]
@@ -106,6 +118,9 @@ ruleTester.run('jsx-no-uselses-fragment', rule, {
           <Foo />
         </React.Fragment>
       `,
+      output: `
+        <Foo />
+      `,
       errors: [{messageId: 'NeedsMoreChidren'}]
     },
     {