Merge pull request #2120 from jomasti/issue-2119

[Fix] `jsx-indent`: Prevent crash on valueless props
jsx-eslint · Jan 4, 2019 · 096161a · 096161a
2 parents 230c7e0 + 9d3955a
commit 096161a
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/rules/jsx-indent.js b/lib/rules/jsx-indent.js
@@ -253,7 +253,7 @@ module.exports = {
     }
 
     function handleAttribute(node) {
-      if (!checkAttributes || node.value.type !== 'JSXExpressionContainer') {
+      if (!checkAttributes || (!node.value || node.value.type !== 'JSXExpressionContainer')) {
         return;
       }
       const nameIndent = getNodeIndent(node.name);

diff --git a/tests/lib/rules/jsx-indent.js b/tests/lib/rules/jsx-indent.js
@@ -820,6 +820,18 @@ const Component = () => (
 );
     `,
     options: ['tab', {checkAttributes: false}]
+  }, {
+    code: `
+    function Foo() {
+      return (
+        <input
+          type="radio"
+          defaultChecked
+        />
+      );
+    }
+    `,
+    options: [2, {checkAttributes: true}]
   }],
 
   invalid: [{