[Fix] jsx-max-depth: avoid a crash

Fixes #2102.
jsx-eslint · Jan 1, 2019 · 146d8d1 · 146d8d1
1 parent dfeeb81
commit 146d8d1
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/lib/rules/jsx-max-depth.js b/lib/rules/jsx-max-depth.js
@@ -89,7 +89,7 @@ module.exports = {
 
             return jsxUtil.isJSX(writeExpr)
               && writeExpr
-              || writeExpr.type === 'Identifier'
+              || (writeExpr && writeExpr.type === 'Identifier')
               && findJSXElementOrFragment(variables, writeExpr.name);
           }
         }
@@ -103,7 +103,7 @@ module.exports = {
 
     function checkDescendant(baseDepth, children) {
       baseDepth++;
-      children.forEach(node => {
+      (children || []).forEach(node => {
         if (!hasJSX(node)) {
           return;
         }

diff --git a/lib/util/jsx.js b/lib/util/jsx.js
@@ -31,7 +31,7 @@ function isDOMComponent(node) {
  * @returns {boolean} Whether or not the node if a JSX element or fragment.
  */
 function isJSX(node) {
-  return ['JSXElement', 'JSXFragment'].indexOf(node.type) >= 0;
+  return node && ['JSXElement', 'JSXFragment'].indexOf(node.type) >= 0;
 }
 
 module.exports = {

diff --git a/tests/lib/rules/jsx-max-depth.js b/tests/lib/rules/jsx-max-depth.js
@@ -94,6 +94,15 @@ ruleTester.run('jsx-max-depth', rule, {
       </tbody>
     `,
     options: [{max: 2}]
+  }, {
+    code: [
+      'const Example = props => {',
+      '  for (let i = 0; i < length; i++) {',
+      '    return <Text key={i} />;',
+      '  }',
+      '};'
+    ].join('\n'),
+    options: [{max: 1}]
   }],
 
   invalid: [{