[Tests] function-component-definition: add passing test cases

Closes #3057
jsx-eslint · Aug 11, 2022 · 23121e0 · 23121e0
1 parent d000f8c
commit 23121e0
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -34,7 +34,9 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 * [readme] remove dead codeclimate badge, add actions badge (@ljharb)
 * [readme] Remove dead david-dm badge ([#3262][] @ddzz)
 * [Refactor] [`jsx-closing-bracket-location`], [`jsx-no-bind`]: fix eslint issues ([#3351][] @caroline223)
+* [Tests] [`function-component-definition`]: add passing test cases ([#3355][] @TildaDares)
 
+[#3355]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3355
 [#3353]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3353
 [#3351]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3351
 [#3350]: https://github.com/jsx-eslint/eslint-plugin-react/pull/3350

diff --git a/tests/lib/rules/function-component-definition.js b/tests/lib/rules/function-component-definition.js
@@ -406,6 +406,45 @@ ruleTester.run('function-component-definition', rule, {
       `,
       options: [{ unnamedComponents: ['arrow-function', 'function-expression'] }],
     },
+    {
+      // should not report non-jsx components
+      code: `
+        export default (key, subTree = {}) => {
+          return (state) => {
+            const dataInStore = getFromDataModel(key)(state);
+            const fullPaths = dataInStore.map((item, index) => {
+              return [key, index];
+            });
+
+            return {
+              key,
+              paths: fullPaths.map((p) => [p[1]]),
+              fullPaths,
+              subTree: Object.keys(subTree).length ? subTree : null,
+            }
+          };
+        }
+      `,
+    },
+    {
+      // should not report non-jsx components
+      code: `
+        function mapStateToProps() {
+          const internItems = makeInternArray();
+          const internClassList = makeInternArray();
+
+          return (state, props) => {
+            const { store, bucket, singleCharacter } = props;
+
+            return {
+              store: null,
+              destinyVersion: store.destinyVersion,
+              storeId: store.id,
+            }
+          }
+        }
+      `,
+    },
   ]),
 
   invalid: parsers.all([