[Fix] jsx-curly-brace-presence: Fix filter of undefined error with …

…whitespace inside jsx attr curlies
jsx-eslint · Oct 11, 2019 · 2a595fd · 2a595fd
1 parent 0c1cb28
commit 2a595fd
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/lib/rules/jsx-curly-brace-presence.js b/lib/rules/jsx-curly-brace-presence.js
@@ -242,12 +242,18 @@ module.exports = {
     }
 
     function hasAdjacentJsxExpressionContainers(node, children) {
+      if (!children) {
+        return false;
+      }
       const childrenExcludingWhitespaceLiteral = children.filter(child => !isWhiteSpaceLiteral(child));
       const adjSiblings = getAdjacentSiblings(node, childrenExcludingWhitespaceLiteral);
 
       return adjSiblings.some(x => x.type && x.type === 'JSXExpressionContainer');
     }
     function hasAdjacentJsx(node, children) {
+      if (!children) {
+        return false;
+      }
       const childrenExcludingWhitespaceLiteral = children.filter(child => !isWhiteSpaceLiteral(child));
       const adjSiblings = getAdjacentSiblings(node, childrenExcludingWhitespaceLiteral);
 

diff --git a/tests/lib/rules/jsx-curly-brace-presence.js b/tests/lib/rules/jsx-curly-brace-presence.js
@@ -145,6 +145,9 @@ ruleTester.run('jsx-curly-brace-presence', rule, {
     {
       code: `<App prop='bar'>{'foo \\n bar'}</App>`
     },
+    {
+      code: `<App prop={ ' ' }/>`
+    },
     {
       code: `<MyComponent prop='bar'>foo</MyComponent>`,
       options: [{props: 'never'}]