Fix: Handle member expressions in jsx-props-no-multi-spaces

Resolves #1881
jsx-eslint · Jul 20, 2018 · 2aa0955 · 2aa0955
1 parent a0100f3
commit 2aa0955
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 5 deletions.
diff --git a/lib/rules/jsx-props-no-multi-spaces.js b/lib/rules/jsx-props-no-multi-spaces.js
@@ -27,12 +27,16 @@ module.exports = {
     const sourceCode = context.getSourceCode();
 
     function getPropName(propNode) {
-      if (propNode.type === 'JSXSpreadAttribute') {
-        return sourceCode.getText(propNode.argument);
-      } else if (propNode.type === 'JSXIdentifier') {
-        return propNode.name;
+      switch (propNode.type) {
+        case 'JSXSpreadAttribute':
+          return sourceCode.getText(propNode.argument);
+        case 'JSXIdentifier':
+          return propNode.name;
+        case 'JSXMemberExpression':
+          return `${getPropName(propNode.object)}.${propNode.property.name}`;
+        default:
+          return propNode.name.name;
       }
-      return propNode.name.name;
     }
 
     function checkSpacing(prev, node) {

diff --git a/tests/lib/rules/jsx-props-no-multi-spaces.js b/tests/lib/rules/jsx-props-no-multi-spaces.js
@@ -58,6 +58,10 @@ ruleTester.run('jsx-props-no-multi-spaces', rule, {
       '  foo {...test}',
       '  bar />'
     ].join('\n')
+  }, {
+    code: '<Foo.Bar baz="quux" />'
+  }, {
+    code: '<Foobar.Foo.Bar.Baz.Qux.Quux.Quuz.Corge.Grault.Garply.Waldo.Fred.Plugh xyzzy="thud" />'
   }],
 
   invalid: [{
@@ -106,5 +110,17 @@ ruleTester.run('jsx-props-no-multi-spaces', rule, {
       {message: 'Expected only one space between "foo" and "test"'},
       {message: 'Expected only one space between "test" and "bar"'}
     ]
+  }, {
+    code: '<Foo.Bar  baz="quux" />',
+    output: '<Foo.Bar baz="quux" />',
+    errors: [
+      {message: 'Expected only one space between "Foo.Bar" and "baz"'}
+    ]
+  }, {
+    code: '<Foobar.Foo.Bar.Baz.Qux.Quux.Quuz.Corge.Grault.Garply.Waldo.Fred.Plugh  xyzzy="thud" />',
+    output: '<Foobar.Foo.Bar.Baz.Qux.Quux.Quuz.Corge.Grault.Garply.Waldo.Fred.Plugh xyzzy="thud" />',
+    errors: [
+      {message: 'Expected only one space between "Foobar.Foo.Bar.Baz.Qux.Quux.Quuz.Corge.Grault.Garply.Waldo.Fred.Plugh" and "xyzzy"'}
+    ]
   }]
 });