[Fix] display-name: fix identifying _ as a capital letter

jsx-eslint · Jul 13, 2022 · 34b54b0 · 34b54b0
1 parent bdbd2a4
commit 34b54b0
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 1 deletion.
diff --git a/lib/util/isFirstLetterCapitalized.js b/lib/util/isFirstLetterCapitalized.js
@@ -6,7 +6,7 @@
  * @returns {Boolean} True if first letter is capitalized.
  */
 function isFirstLetterCapitalized(word) {
-  if (!word) {
+  if (!word || word.charAt(0) === '_') {
     return false;
   }
   const firstLetter = word.charAt(0);

diff --git a/tests/lib/rules/display-name.js b/tests/lib/rules/display-name.js
@@ -597,6 +597,22 @@ ruleTester.run('display-name', rule, {
           return f(a);
         };`,
     },
+    {
+      // issue #3334
+      code: `
+        obj._property = (a) => {
+          if (a == null) return null;
+          return f(a);
+        };`,
+    },
+    {
+      // issue #3334
+      code: `
+        _variable = (a) => {
+          if (a == null) return null;
+          return f(a);
+        };`,
+    },
     {
       // issue #3303
       code: `

diff --git a/tests/util/isFirstLetterCapitalized.js b/tests/util/isFirstLetterCapitalized.js
@@ -14,6 +14,8 @@ describe('isFirstLetterCapitalized', () => {
   it('should return false for uncapitalized string', () => {
     assert.equal(isFirstLetterCapitalized('isCapitalized'), false);
     assert.equal(isFirstLetterCapitalized('lowercase'), false);
+    assert.equal(isFirstLetterCapitalized('_startsWithUnderscore'), false);
+    assert.equal(isFirstLetterCapitalized('_StartsWithUnderscore'), false);
   });
 
   it('should return true for capitalized string', () => {