Test async functions and generators

jsx-eslint · May 8, 2019 · 4012bee · 4012bee
1 parent 061d497
commit 4012bee
Show file tree

Hide file tree

Showing 2 changed files with 124 additions and 4 deletions.
diff --git a/lib/rules/no-unused-class-component-methods.js b/lib/rules/no-unused-class-component-methods.js
@@ -61,10 +61,6 @@ module.exports = {
       return isMethod || isArrowFunction;
     };
     const checkMethods = node => {
-      if (isNotComponent(node)) {
-        return;
-      }
-
       const properties = astUtil.getComponentProperties(node);
       let methods = properties
         .filter(property => (
@@ -149,6 +145,10 @@ module.exports = {
         const list = components.list();
 
         Object.values(list).forEach(({ node }) => {
+          if (isNotComponent(node)) {
+            return;
+          }
+
           checkMethods(node);
         });
       }

diff --git a/tests/lib/rules/no-unused-class-component-methods.js b/tests/lib/rules/no-unused-class-component-methods.js
@@ -178,6 +178,56 @@ ruleTester.run('no-unused-class-component-methods', rule, {
         }
       `,
       parser: 'babel-eslint'
+    },
+    {
+      code: `
+        class Foo extends React.Component {
+          action = async () => {}
+          render() {
+            return <button onClick={this.action}>Click</button>;
+          }
+        }
+      `,
+      parser: 'babel-eslint'
+    },
+    {
+      code: `
+        class Foo extends React.Component {
+          async action() {
+            console.log('error');
+          }
+          render() {
+            return <button onClick={() => this.action()}>Click</button>;
+          }
+        }
+      `,
+      parser: 'babel-eslint'
+    },
+    {
+      code: `
+        class Foo extends React.Component {
+          * action() {
+            console.log('error');
+          }
+          render() {
+            return <button onClick={() => this.action()}>Click</button>;
+          }
+        }
+      `,
+      parser: 'babel-eslint'
+    },
+    {
+      code: `
+        class Foo extends React.Component {
+          async * action() {
+            console.log('error');
+          }
+          render() {
+            return <button onClick={() => this.action()}>Click</button>;
+          }
+        }
+      `,
+      parser: 'babel-eslint'
     }
   ],
 
@@ -232,6 +282,76 @@ ruleTester.run('no-unused-class-component-methods', rule, {
         line: 3,
         column: 11
       }]
+    },
+    {
+      code: `
+        class Foo extends React.Component {
+          action = async () => {}
+          render() {
+            return null;
+          }
+        }
+      `,
+      parser: 'babel-eslint',
+      errors: [{
+        message: 'Unused method "action" of class "Foo"',
+        line: 3,
+        column: 11
+      }]
+    },
+    {
+      code: `
+        class Foo extends React.Component {
+          async action() {
+            console.log('error');
+          }
+          render() {
+            return null;
+          }
+        }
+      `,
+      parser: 'babel-eslint',
+      errors: [{
+        message: 'Unused method "action" of class "Foo"',
+        line: 3,
+        column: 11
+      }]
+    },
+    {
+      code: `
+        class Foo extends React.Component {
+          * action() {
+            console.log('error');
+          }
+          render() {
+            return null;
+          }
+        }
+      `,
+      parser: 'babel-eslint',
+      errors: [{
+        message: 'Unused method "action" of class "Foo"',
+        line: 3,
+        column: 11
+      }]
+    },
+    {
+      code: `
+        class Foo extends React.Component {
+          async * action() {
+            console.log('error');
+          }
+          render() {
+            return null;
+          }
+        }
+      `,
+      parser: 'babel-eslint',
+      errors: [{
+        message: 'Unused method "action" of class "Foo"',
+        line: 3,
+        column: 11
+      }]
     }
   ]
 });