[Fix] prop-types: avoid crash on used prevProps

Fixes #2095.
jsx-eslint · Jan 2, 2019 · 4da90ea · 4da90ea
1 parent 0202de3
commit 4da90ea
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 6 deletions.
diff --git a/lib/util/usedPropTypes.js b/lib/util/usedPropTypes.js
@@ -379,15 +379,18 @@ module.exports = function usedPropTypesInstructions(context, components, utils)
         }
 
         const nodeSource = sourceCode.getText(node);
-        const isDirectProp = DIRECT_PROPS_REGEX.test(nodeSource) || DIRECT_NEXT_PROPS_REGEX.test(nodeSource);
+        const isDirectProp = DIRECT_PROPS_REGEX.test(nodeSource)
+          || DIRECT_NEXT_PROPS_REGEX.test(nodeSource)
+          || DIRECT_PREV_PROPS_REGEX.test(nodeSource);
+        const reportedNode = (
+          !isDirectProp && !inConstructor() && !inComponentWillReceiveProps() ?
+            node.parent.property :
+            node.property
+        );
         usedPropTypes.push({
           name: name,
           allNames: allNames,
-          node: (
-            !isDirectProp && !inConstructor() && !inComponentWillReceiveProps() ?
-              node.parent.property :
-              node.property
-          )
+          node: reportedNode
         });
         break;
       case 'destructuring':

diff --git a/tests/lib/rules/prop-types.js b/tests/lib/rules/prop-types.js
@@ -2247,6 +2247,36 @@ ruleTester.run('prop-types', rule, {
         query: PropTypes.string,
       };
       `
+    },
+    {
+      code: [
+        'export default class LazyLoader extends Component {',
+        '  static propTypes = {',
+        '    children: PropTypes.node,',
+        '    load: PropTypes.any,',
+        '  };',
+        '  state = { mod: null };',
+        '  shouldComponentUpdate(prevProps) {',
+        '    assert(prevProps.load === this.props.load);',
+        '    return true;',
+        '  }',
+        '  load() {',
+        '    this.props.load(mod => {',
+        '      this.setState({',
+        '        mod: mod.default ? mod.default : mod',
+        '      });',
+        '    });',
+        '  }',
+        '  render() {',
+        '    if (this.state.mod !== null) {',
+        '      return this.props.children(this.state.mod);',
+        '    }',
+        '    this.load();',
+        '    return null;',
+        '  }',
+        '}'
+      ].join('\n'),
+      parser: 'babel-eslint'
     }
   ],