Merge pull request #1560 from jomasti/issue-1559

Fix crash in no-access-state-in-setstate
jsx-eslint · Nov 21, 2017 · 6829c5c · 6829c5c
2 parents f06db3d + 9cbd67e
commit 6829c5c
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/rules/no-access-state-in-setstate.js b/lib/rules/no-access-state-in-setstate.js
@@ -95,7 +95,7 @@ module.exports = {
                 node: node
               });
               break;
-            } else if (current.type === 'FunctionExpression') {
+            } else if (current.type === 'FunctionExpression' && current.parent.key) {
               methods.push({
                 methodName: current.parent.key.name,
                 node: node

diff --git a/tests/lib/rules/no-access-state-in-setstate.js b/tests/lib/rules/no-access-state-in-setstate.js
@@ -46,6 +46,24 @@ ruleTester.run('no-access-state-in-setstate', rule, {
       '});'
     ].join('\n'),
     parserOptions: parserOptions
+  }, {
+    // issue 1559: don't crash
+    code: `
+      var SearchForm = createReactClass({
+        render: function () {
+          return (
+            <div>
+              {(function () {
+                if (this.state.prompt) {
+                  return <div>{this.state.prompt}</div>
+                }
+              }).call(this)}
+            </div>
+          );
+        }
+      });
+    `,
+    parserOptions: parserOptions
   }],
 
   invalid: [{